-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD: Bump numpy version to>=1.20.0,<2.3 #5557
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5557 +/- ##
==========================================
- Coverage 85.30% 85.30% -0.01%
==========================================
Files 151 151
Lines 60822 60822
==========================================
- Hits 51886 51884 -2
- Misses 8936 8938 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for all the previous tasks of yours that allowed us to eventually bump numpy.
@SMoraisAnsys COuld we merge right? |
@Samuelopez-ansys Let's wait for #5555 merging before merging. I would prefer to check after the .NET changes since they might interact as it was happening in previews PRs. |
Updating after merging #5555, let's see how things go ! |
Description
Follow up of #5116 and #5116 to bump numpy's version bound.
Previously we had issues associated to .NET and TOML handling but most of them have been taken care of. The last thing standing should be fixed with #5555.
Checklist