Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Bump numpy version to>=1.20.0,<2.3 #5557

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Dec 11, 2024

Description

Follow up of #5116 and #5116 to bump numpy's version bound.
Previously we had issues associated to .NET and TOML handling but most of them have been taken care of. The last thing standing should be fixed with #5555.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.30%. Comparing base (5ea126b) to head (a841aae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5557      +/-   ##
==========================================
- Coverage   85.30%   85.30%   -0.01%     
==========================================
  Files         151      151              
  Lines       60822    60822              
==========================================
- Hits        51886    51884       -2     
- Misses       8936     8938       +2     

@SMoraisAnsys SMoraisAnsys self-assigned this Dec 11, 2024
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for all the previous tasks of yours that allowed us to eventually bump numpy.

@Samuelopez-ansys
Copy link
Member

@SMoraisAnsys COuld we merge right?

@SMoraisAnsys
Copy link
Collaborator Author

@Samuelopez-ansys Let's wait for #5555 merging before merging. I would prefer to check after the .NET changes since they might interact as it was happening in previews PRs.

@SMoraisAnsys
Copy link
Collaborator Author

Updating after merging #5555, let's see how things go !

@SMoraisAnsys SMoraisAnsys merged commit 7a528df into main Dec 13, 2024
43 checks passed
@SMoraisAnsys SMoraisAnsys deleted the build/bump-numpy-version branch December 13, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants