Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Export from 3D layout to 3D modeler with keeping net names bug fix #4582

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

svandenb-dev
Copy link
Collaborator

Initial setting used were causing failure on some design. du to precision difference between 3D modeler and EDB.
Taking coarser value resolve the issue

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@svandenb-dev svandenb-dev linked an issue Apr 23, 2024 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Apr 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.54%. Comparing base (d1a2049) to head (a1a7cfc).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4582       +/-   ##
===========================================
+ Coverage   34.39%   81.54%   +47.15%     
===========================================
  Files         110      110               
  Lines       53753    53753               
===========================================
+ Hits        18487    43833    +25346     
+ Misses      35266     9920    -25346     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 075d820 into main Apr 24, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the FIX-export-to-hfss-keep-net-name branch April 24, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Export 3D layout to 3D modeler with keeping net names
4 participants