Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/4547 keyword conventions #4559

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Doc/4547 keyword conventions #4559

merged 6 commits into from
Apr 24, 2024

Conversation

Devin-Crawford
Copy link
Contributor

Update Contributing.rst

@Devin-Crawford Devin-Crawford linked an issue Apr 20, 2024 that may be closed by this pull request
Update Contrbuting.rst to reflect keyword conventions. #4547
Closed
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.53%. Comparing base (d1a2049) to head (b16d693).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4559       +/-   ##
===========================================
+ Coverage   34.39%   81.53%   +47.13%     
===========================================
  Files         110      110               
  Lines       53753    53753               
===========================================
+ Hits        18487    43826    +25339     
+ Misses      35266     9927    -25339

@Devin-Crawford Devin-Crawford requested a review from PipKat April 22, 2024 17:20
@Devin-Crawford Devin-Crawford marked this pull request as ready for review April 22, 2024 17:20
PipKat
PipKat previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicks to adjust content to the Google style guide!

@Devin-Crawford @PipKat
Apply suggestions from code review
65a2188 
Linguistic suggestions from @PipKat

Co-authored-by: Kathy Pippert <[email protected]>
MaxJPRey
MaxJPRey approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

SMoraisAnsys
SMoraisAnsys approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, following these guidelines will make the code easier to read and maintain. Btw, good idea to quote PEP !

@Devin-Crawford Devin-Crawford merged commit 87739a9 into main Apr 24, 2024
15 checks passed
@Devin-Crawford Devin-Crawford deleted the doc/4547-keyword-conventions branch April 24, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@PipKat PipKat PipKat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Contrbuting.rst to reflect keyword conventions.
6 participants
@Devin-Crawford @codecov-commenter @PipKat @Samuelopez-ansys @MaxJPRey @SMoraisAnsys