Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2024 March Bug fixes for Cloud VM logic on section 1.2.x, Improved Reboot Handler and SID Logic Improvement #31

Merged
merged 12 commits into from
Mar 19, 2024
Merged

2024 March Bug fixes for Cloud VM logic on section 1.2.x, Improved Reboot Handler and SID Logic Improvement #31

merged 12 commits into from
Mar 19, 2024

Conversation

frederickw082922
Copy link
Contributor

Overall Review of Changes:
Thank you @MrSteve81 for the enhancements to this release!

  • Improved 19.x section logic for Windows local user SIDs and HKU support.
  • Reboot handler and logic Improvement with skip_reboot var feature.
  • win_skip_for_test var update with additional description and supported controls of 2.2.20, 2.2.25, and 2.2.26.
  • Mislabeled control fix for win22cis_rule_18_9_7_2
  • Improved logic for win22cis_cloud_based_system 1.2.x controls.

Issue Fixes:
N/A

Enhancements:
Improved Reboot Handler and SID user Logic for all local accounts

How has this been tested?:
Locally and Azure

@frederickw082922
Update cloud_lockout logic
da357f4 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
Update section 19 with loop and change_requires_reboot
031cdcd 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
Update handeler name to change_requires_reboot
06cc295 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
Fix 18.9.7.2 title and var
d3cdda0 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
Fix 18.10.89.2.2 reg value
550bd56 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
Update meta
9bebc1c 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
defaults main var update
9e1d76a 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
update section5 with handeler name chance
fece5ca 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
update win_skip_for_test withe latest controls
e6108d3 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
update changelog
874e9f8 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
Update ChangeLog with @mr.Steve81
0ef7269 
Signed-off-by: Frederick Witty <[email protected]>
@frederickw082922
Typo Fixes
18e1212 
Signed-off-by: Frederick Witty <[email protected]>
uk-bolly
uk-bolly approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@frederickw082922 frederickw082922 merged commit 6aa6445 into devel Mar 19, 2024
3 checks passed
@frederickw082922 frederickw082922 deleted the 2024_FEB_UPDATE branch April 1, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uk-bolly uk-bolly uk-bolly approved these changes

@MrSteve81 MrSteve81 Awaiting requested review from MrSteve81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederickw082922 @uk-bolly