Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nov23 improvements #117

Merged
merged 14 commits into from
Dec 12, 2023
Merged

Nov23 improvements #117

merged 14 commits into from
Dec 12, 2023

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:

  • updated goss binary to 0.4.4
  • moved majority of audit variables to vars/audit.yml
  • new function to enable audit_only using remediation
  • removed some dupes in audit config

How has this been tested?:
Manually and audit only tested

uk-bolly added 13 commits October 23, 2023 09:08
@uk-bolly
lint update
963aaf4 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Updated grub user usage and warning based on #106
c39816e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated 3.1.1 thanks to @LoZZoL U22
15bafe2 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
typo fix
b93c00e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated thanks to @LoZZoL u22
8435085 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated quotes around mode
c0efed3 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge branch 'devel' into Oct23_improvements
67a1e20
@uk-bolly
fixed typo
ccc6e5f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated var name
2192875 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed dupes
596983f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
0824786 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
ability to audit_only
63891a2 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
tidy up on test 3.1.1
0f02967 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested a review from georgenalen November 21, 2023 17:15
@uk-bolly
Copy link
Member Author

Note: Will fail until audit merged

georgenalen
georgenalen approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit c10bca7 into devel Dec 12, 2023
4 checks passed
@uk-bolly uk-bolly deleted the nov23_improvements branch December 12, 2023 15:12
@uk-bolly uk-bolly mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgenalen georgenalen georgenalen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uk-bolly @georgenalen