Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ufw typo in 3.5.1.5 #84

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

dderemiah
Copy link
Contributor

Overall Review of Changes:
Found a typo in rule 3.5.1.5

Issue Fixes:
says default: but should be a rule: to allow outbound

Enhancements:
n/a
How has this been tested?:
tested locally

Signed-off-by: Dan D <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @dderemiah

The setting is to set all outgoing connecting to allow. This has been done by changing the default outgoing to allow.
Does this not work the way it is documented or do you feel having it as a rule rather than default allow?
thanks

uk-bolly

@dderemiah
Copy link
Contributor Author

The result after running the role is outbound deny. I compared the code wit the UB22-CIS which works and reconciled the difference to the UB18 code. There is a control later (3.5.1.7) that sets the default to deny.

@uk-bolly uk-bolly merged commit 32e5dea into ansible-lockdown:devel Nov 9, 2023
3 checks passed
@uk-bolly
Copy link
Member

uk-bolly commented Nov 9, 2023

The result after running the role is outbound deny. I compared the code wit the UB22-CIS which works and reconciled the difference to the UB18 code. There is a control later (3.5.1.7) that sets the default to deny.

Fantastic thank you @dderemiah that makes complete sense

@dderemiah dderemiah deleted the typo_3.5.1.5 branch November 9, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants