Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3R14 to main release #477

Merged
merged 111 commits into from
Nov 14, 2024
Merged

V3R14 to main release #477

merged 111 commits into from
Nov 14, 2024

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Oct 29, 2024 •
edited
Loading

Overall Review of Changes:

  • Audit updated

    • moved audit into prelim
    • updates to audit logic for copy and archive options

  • RHEL-07-020019 - title and ruleid update

  • RHEL-07-020022 - ruleid update

  • RHEL-07-020210 - ruleid update

  • RHEL-07-020220 - ruleid update

  • RHEL-07-020100 - ruleid update and bin/false

  • RHEL-07-020101 - ruleid update and bin/false

  • RHEL-07-040180 - ruleid update and bin/false

  • RHEL-07-040190 - ruleid update and bin/false

Issue Fixes:
Pre-commits

Enhancements:
Audit updates X86_64 and ARM64
Pipeline updates
General improvements
jmespath removal
Rebase carried out due to historical issues

How has this been tested?:
Manually and Pipeline

anzoman and others added 30 commits September 15, 2023 10:48
@anzoman
Specify missing state parameter for package
f117074 
Signed-off-by: Anže Luzar <[email protected]>
@anzoman
Correct with_items indentation for package
130e021 
Signed-off-by: Anže Luzar <[email protected]>
@anzoman
Replace inline strings with module parameters
601ef18 
Signed-off-by: Anže Luzar <[email protected]>
@uk-bolly
Merge pull request #437 from anzoman/steampunk-spotter-fixes
b53d7be 
Task validation fixes and rewrites (by Steampunk Spotter)
@uk-bolly
updated link
dfb9791 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
lint updates
5108506 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed old
223624e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added new defined secrets file
20a720a 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added precommit
5956a0f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge pull request #438 from ansible-lockdown/discord_updates
395956a 
Discord updates, lint and tidy
@uk-bolly
lint updates
aa000e8 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
d14af2e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
added pragma allow list
1dc0f9b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated due to galaxy changes
6098b02 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
moved file
197f961 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated path
d49469b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed quality badge since galaxy-ng
5aae574 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge pull request #439 from ansible-lockdown/collections_lint
32fe8c1 
Collections lint
@layluke
Adding additional condition for rhel7stig_grub2_user_cfg for task
fb6f4fe 
Signed-off-by: layluke <[email protected]>
@uk-bolly
Merge pull request #441 from layluke/440-Grub_Handler_Fix
5e47e97 
Adding additional condition for rhel7stig_grub2_user_cfg for task
@uk-bolly
updated version
88f570b 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
quoted version
ea14041 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated rule id 020230
c48ab81 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
rule ids and inactive variable added
d602fd9 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
f480204 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated the workflow version and galaxy setup
6a7137f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated the workflow version and galaxy setup
b3f3248 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge pull request #442 from ansible-lockdown/workflow_galaxy
d26e104 
updated the workflow version and galaxy setup
@uk-bolly
removed file
d687371 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated
9dd216c 
Signed-off-by: Mark Bolwell <[email protected]>
uk-bolly and others added 16 commits September 17, 2024 17:26
@uk-bolly
updated default var to use discovered value
f2baee2 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Alignment
b38ce35 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
remove jmespath on the way mountspoints are check
cbeab4a 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
removed breaking dupe line
594c50f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Updated goss version and added ARM
c6d2e06 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
updated mount and wireless checks
a94da63 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
aligned benchmark git version name
272ce78 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge branch 'devel' into stig_v3r14
6304b8d 
Signed-off-by: uk-bolly <[email protected]>
@uk-bolly
removed empty line
06d5a34 
Signed-off-by: Mark Bolwell <[email protected]>
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
df0e444 
updates:
- [github.com/ansible-community/ansible-lint: v24.9.0 → v24.9.2](ansible/ansible-lint@v24.9.0...v24.9.2)
@uk-bolly
Merge pull request #474 from ansible-lockdown/pre-commit-ci-update-co…
5b6660e 
…nfig

[pre-commit.ci] pre-commit autoupdate
@uk-bolly
Merge pull request #473 from ansible-lockdown/stig_v3r14
ebad8d3 
Stig v3r14
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
0b0049a 
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
- [github.com/gitleaks/gitleaks: v8.19.2 → v8.21.1](gitleaks/gitleaks@v8.19.2...v8.21.1)
@uk-bolly
Merge pull request #475 from ansible-lockdown/pre-commit-ci-update-co…
2e45c3d 
…nfig

[pre-commit.ci] pre-commit autoupdate
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
e904997 
updates:
- [github.com/gitleaks/gitleaks: v8.21.1 → v8.21.2](gitleaks/gitleaks@v8.21.1...v8.21.2)
@uk-bolly
Merge pull request #476 from ansible-lockdown/pre-commit-ci-update-co…
3623e05 
…nfig

[pre-commit.ci] pre-commit autoupdate
@uk-bolly uk-bolly requested a review from georgenalen October 29, 2024 15:07
@uk-bolly
Copy link
Member Author

pipeline failure expected due to new pipeline config
see manually run on new pipeline with a manual run
https://github.com/ansible-lockdown/RHEL7-STIG/actions/runs/11577296930

@uk-bolly uk-bolly marked this pull request as ready for review October 30, 2024 07:44
MrSteve81
MrSteve81 previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice large Update. Well done!

@uk-bolly
updated layout 21350
0e839b7 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
fixed layout 041010
18f123f 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
moved check_mode
aa0be1c 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
moved check_mode
744f42e 
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Merge pull request #478 from ansible-lockdown/Oct24
b223ae5 
Oct24 updated
georgenalen
georgenalen approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit 1651ba2 into main Nov 14, 2024
5 of 6 checks passed
@uk-bolly
Copy link
Member Author

Main pipeline expected to fail as moved to new workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgenalen georgenalen georgenalen approved these changes

@MrSteve81 MrSteve81 MrSteve81 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@uk-bolly @georgenalen @MrSteve81 @anzoman @layluke @frederickw082922