Correct 4.1.15 sudo audit syntax #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Davison <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
Merged
uk-bolly
added a commit
that referenced
this pull request
May 1, 2024
* #18 corrected Signed-off-by: Mark Bolwell <[email protected]> * updated due to #19 great catch Signed-off-by: Mark Bolwell <[email protected]> * V2.0.0 final release (#24) * removed warn: false Signed-off-by: Mark Bolwell <[email protected]> * fix typos Signed-off-by: Mark Bolwell <[email protected]> * addressed #21 Signed-off-by: Mark Bolwell <[email protected]> * updated 1.1.2 logic Signed-off-by: Mark Bolwell <[email protected]> * updated handler Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]> * Correct 4.1.15 sudo audit syntax (#26) Signed-off-by: Andrew Davison <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Andrew Davison <[email protected]> Co-authored-by: Andrew Davison <[email protected]>
mfortin
pushed a commit
to mfortin/AMAZON2-CIS
that referenced
this pull request
Jun 7, 2024
* ansible-lockdown#18 corrected Signed-off-by: Mark Bolwell <[email protected]> * updated due to ansible-lockdown#19 great catch Signed-off-by: Mark Bolwell <[email protected]> * V2.0.0 final release (ansible-lockdown#24) * removed warn: false Signed-off-by: Mark Bolwell <[email protected]> * fix typos Signed-off-by: Mark Bolwell <[email protected]> * addressed ansible-lockdown#21 Signed-off-by: Mark Bolwell <[email protected]> * updated 1.1.2 logic Signed-off-by: Mark Bolwell <[email protected]> * updated handler Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]> * Correct 4.1.15 sudo audit syntax (ansible-lockdown#26) Signed-off-by: Andrew Davison <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Andrew Davison <[email protected]> Co-authored-by: Andrew Davison <[email protected]> Signed-off-by: fortinm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
The correct syntax for auditd rules is -a action,filter.
The CIS Benchmark is inconsistent on this between remediation and verification on 32 vs 64 bit and the -F typo appears to have come from a line wrap issue with the CIS Benchmark example.
The rest of this same file uses
-a always,exitexcept these two lines, and the AMAZON2-CIS-Audit tests also check for the correct-a always,exithttps://github.com/ansible-lockdown/AMAZON2-CIS-Audit/blob/devel/section_4/cis_4.1/cis_4.1.15.yml
I also found this discussion from 2014 about the ordering:
https://listman.redhat.com/archives/linux-audit/2014-April/009031.html
How has this been tested?:
We have run it against an Amazon Linux 2 EC2 instance and then ran the AMAZON2-CIS-Audit repo tests against it.