Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 22 #23

Closed
wants to merge 6 commits into from
Closed

Issue 22 #23

wants to merge 6 commits into from

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented Feb 12, 2024

Overall Review of Changes:
Fixing issue #22 about deprecated usage for warn: false in command/shell

Issue Fixes:
Issue #22

Enhancements:
Using FQCN for modules.

How has this been tested?:
Executed the role pulled from this branch.
Ran ansible-lint.

Before:

TASK [AMAZON2-CIS : 1.2.2 | AUDIT | Ensure package manager repositories are configured | Get repo list] ***
fatal: [10.0.0.2]: FAILED! => changed=false
  msg: 'Unsupported parameters for (ansible.legacy.command) module: warn. Supported parameters include: _raw_params, _uses_shell, argv, chdir, creates, executable, expand_argument_vars, removes, stdin, stdin_add_newline, strip_empty_ends.'

Now:

TASK [AMAZON2-CIS : 1.2.2 | AUDIT | Ensure package manager repositories are configured | Get repo list] ***
ok: [10.0.0.3]

Signed-off-by: Mathieu Fortin <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Copy link
Contributor Author

mfortin commented Mar 21, 2024

This is no longer required as Ansible support for recent version was addressed in #24

@mfortin mfortin closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant