Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified 4 appliance targets #558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

prabinovRedhat
Copy link
Contributor

Modified 4 appliance tests to run on real vCenter env:

  • appliance_infraprofile_configs
  • appliance_localaccounts
  • appliance_monitoring
  • appliance_networking_dns_hostname

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (4ec82d4) to head (0f3655b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   37.05%   37.05%           
=======================================
  Files         145      145           
  Lines       11395    11395           
  Branches     2261     2261           
=======================================
  Hits         4222     4222           
  Misses       7173     7173           
Flag Coverage Δ
sanity 37.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prabinovRedhat
Copy link
Contributor Author

cc: @shellymiron @anna-savina

Copy link
Contributor


- name: Print local accounts
ansible.builtin.debug:
var: local_accounts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't restore warn_days. Add always block please to restore warn_days to original value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


- name: Query the monitoring backend for memory usage
vmware.vmware_rest.appliance_monitoring_query:
end_time: 2021-04-14T09:34:56.000Z
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try more recent dates. You've got an empty result.

    "monitoring_query_result": {
        "changed": false,
        "failed": false,
        "value": [
            {
                "data": [
                    "",
                    "",
                    "",
                    "",
                    "",
                    "",
                    "",
                    "",
                    "",
                    "",
                    "",
                    "",
                    ""
                ],
                "end_time": "2021-04-14T09:34:56.000Z",
                "function": "AVG",
                "interval": "MINUTES5",
                "name": "mem.total",
                "start_time": "2021-04-14T08:34:56.000Z"
            }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@prabinovRedhat prabinovRedhat force-pushed the modify_appliance branch 2 times, most recently from ce29554 to b031097 Compare November 28, 2024 14:33
Copy link
Contributor

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants