Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev container #140

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Dev container #140

merged 3 commits into from
Oct 25, 2024

Conversation

Tom-Latham
Copy link
Collaborator

SUMMARY

Updated devcontainer to use a public image for building

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

DevContainer

ADDITIONAL INFORMATION

Dev container now uses a public python image and installs Ansible in the post-setup script. Also updated the default directory when opening a new terminal in the container to be the root of this repo


Copy link
Collaborator

@andrewhughes101 andrewhughes101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Think at some point we should still make this less opinionated by removing the ruff support and pyproject toml, but for now this is a good starting point

Copy link
Collaborator

@andrewhughes101 andrewhughes101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor whitespace fixup

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@Tom-Latham
Copy link
Collaborator Author

Re-launch CI

@Tom-Latham
Copy link
Collaborator Author

Re-launch CI

@Tom-Latham Tom-Latham merged commit 8555928 into main Oct 25, 2024
4 checks passed
@Tom-Latham Tom-Latham deleted the dev-container branch October 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants