-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios_users - Replace old module ios_user #909
base: main
Are you sure you want to change the base?
ios_users - Replace old module ios_user #909
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
+ Coverage 86.79% 87.00% +0.20%
==========================================
Files 196 204 +8
Lines 12253 12373 +120
==========================================
+ Hits 10635 10765 +130
+ Misses 1618 1608 -10 |
d473625
to
86f5f9b
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 53s |
fed452a
to
baa3daf
Compare
Replace the module ios_user with a more standard file coverage. And also take correctly some parts of the commands (by example, the current module doesn't take correctly the `privilege`part of the username command
baa3daf
to
fc60ee7
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 40s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 46s |
e422634
to
cfa0819
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 46s |
This comment was marked as resolved.
This comment was marked as resolved.
cfa0819
to
6d52861
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 45s |
9c5fb26
to
dcc8862
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 42s |
c4fea10
to
cf1e56d
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 59s |
3a1816e
to
d79848f
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 49s |
@KB-perByte : Ok: I have updated the PR as requested. So, now, I have some questions:
And I have also a last question regarding the test task Thanks a lot. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 41s |
the remote device.
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 37s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 29s |
Replace the module ios_user with a more standard file coverage. And also take correctly some parts of the commands (by example, the current module doesn't take correctly the `privilege`part of the username command
Currently, on IOS devices, when you enter a `no username` command, the system request you a question to confirm the suppression. To handle this part, I have done some change: - I have "created" the module IosNetworkTemplate, a override class of NetworkTemplate that take care the case of commands with a specific prompt - The ios_user_global module use this class for the User_globalTemplate Second point, this module allow you to create the username by using the old command line (C(username)) or the new one (C(user-name)). I have done this part in a super class to allow other template module to use this possibility. I don't have done a super class for the assert function in tests module. If you want, I can try to do it also.
for more information, see https://pre-commit.ci
As requested. I have also added the deprecation notice for ios_user module
for more information, see https://pre-commit.ci
the remote device.
…ios into update_ios_user_global
20060e8
to
8b3767e
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 29s |
SUMMARY
Replace the module ios_user with a more standard file coverage. And also take correctly some parts of the commands (by example, the current module doesn't take correctly the
privilege
part of the username commandISSUE TYPE
COMPONENT NAME
ios_users
ADDITIONAL INFORMATION
Module to manage the users and enable on IOS with the following parts:
enable
per levelHere an example of the configuration
And the command generated: