-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object-group service support #1148
base: main
Are you sure you want to change the base?
Conversation
feature/Add-OG-service-support
for more information, see https://pre-commit.ci
@ArchelonU Could you please add some tests to verify the change |
Add description for service_object_group
for more information, see https://pre-commit.ci
@roverflow I have run tests in my branch, added fixes. Now as far as I understand, it requires approval to run testing here. Correct me if I'm wrong. Thx! |
feature/Add-OG-service-support add changelog yaml
@ArchelonU, could you please add a new unit test for this change? You can find the existing tests for acls in the tests folder, you can either modify the test to make use of the new attribute you have added or add a new test function. Thanks |
Feature/add og service support
Add tests service object-group
for more information, see https://pre-commit.ci
SUMMARY
Adding the ability to specify an object group of services in the ACL settings.
ISSUE TYPE
COMPONENT NAME
acls.py
ADDITIONAL INFORMATION
Now you can add object-group service when creating ACL rule.
To do this, it is enough to specify a new variable "service_object_group":
What actually translates into a command: