Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow object to move to right edge and bottom edge and allow scroll of note fields when not using IO #3630

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

krmanik
Copy link
Contributor

@krmanik krmanik commented Dec 11, 2024

Add window: If you toggle the mask editor and navigate to the fields section, you cannot scroll using the mousepad or the mouse scroll wheel. If you attempt to, the "mask editor" will be scrolled instead.

#3608

Zoom in as much as possible when making/editing an IO card.
Try to make an occlusion such that its edge is touching the edge of the image itself.
The edge of the occlusion doesn’t touch the edge of the image, there is a gap.

#3581

@@ -288,9 +288,9 @@ export const makeShapesRemainInCanvas = (canvas: fabric.Canvas, boundingBox: fab
const left = obj.left!;

const topBound = boundingBox.top!;
const bottomBound = topBound + boundingBox.height!;
const bottomBound = topBound + boundingBox.height! + 5;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The width and height less than the value is not drawn, so using that value fixes edge problems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the root issue is the user can tap on the screen / make a very small gesture, and end up creating a rectangle only a pixel or two in width. It then doesn't get rendered on the screen, so the user ends up with an invisible box that still counts as an occlusion. Does that sound correct @krmanik? Or am I thinking of another issue?

If my memory is correct here, maybe another solution would be refusing to create the shapes if they're below a certain size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is before and after screen recording, I think above is different issues, but not sure.

Before

Screen.Recording.2024-12-15.at.12.49.15.PM.mov

After

Screen.Recording.2024-12-15.at.12.48.12.PM.mov

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dae That's a different issue (can't remember whether it was fixed)

@abdnh
Copy link
Collaborator

abdnh commented Dec 11, 2024

(Formatting needs to be fixed)

@abdnh abdnh merged commit 65fd461 into ankitects:main Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants