Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deck options - clarify 2 separate timers #248

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Danika-Dakika
Copy link
Collaborator

Folks seem to get confused about these timers a lot. I think clarifying there are 2 separate timers will help. I'd like to also change the name of the options for the on-screen timer, but that might be excessive.

Potential in-app updates:

  1. Header of the deck options section: TimerTimers
    • I've already done this for the manual in this PR, so the questions are -- is this worth changing in the manual, and does it need to change in the app to match? If it doesn't make sense to do it, I'll revert it here
  2. Name of the option: Show answer timerShow on-screen timer
  3. Name of the option: Stop timer on answerStop on-screen timer (or Stop on-screen timer on answer)
    • I didn't make these changes (2 & 3) yet for the manual, because changing feature-names is a bigger deal. Thoughts?
  4. [There's another string in anki/ftl/core/scheduling.ftl that is similar, but I'm not sure how it's related.]

Tooltip updates:

  1. To match the text -- Once this language is locked, I will do a PR on anki/ftl/core/deck-config.ftl (I think that's the right spot) to add "-2" lines for:
    • On the review screen, show a timer that counts the time you're taking to study each card.
    • Whether to stop the on-screen timer when the answer is revealed. This doesn't affect statistics.
  2. If the header and option names are changed (1, 2, 3 above) [or are these just shared labels between the options and the tooltips?]

@brishtibheja
Copy link
Contributor

brishtibheja commented Aug 18, 2024

I'd like to also change the name of the options for the on-screen timer, but that might be excessive.

It seems to me that readers of the manual are usually not as confused as other users are. I'm not against the changes you made, they'll certainly help some people. But might not the confusion be coming from what we use in the UI? This should be discussed in the forums. The rest of the points:

  1. Maybe we can do better. Plurals aren't that consistent across languages, and sometimes translators even ignore them.
  2. Good change.
  3. Too long but still better.
  4. Is this used somewhere? There are unused strings lying around and some are used in deck options but are coming from scheduling.ftl file.
  5. I don't think we add a "-2" to the key here.
  6. The headers in markdown are only used as comments AFAIK. They don't necessarily need changing.

@brishtibheja
Copy link
Contributor

@Danika-Dakika In case you do some other changes in this file (while you're at it), I'm doing the whole section in #250, just remembered this one so will probably not touch "Timer".

@Danika-Dakika
Copy link
Collaborator Author

In case you do some other changes in this file (while you're at it)

I don't plan on expanding this PR beyond "Timer" -- and the list of collateral damage above,

@dae
Copy link
Member

dae commented Sep 7, 2024

  • Proposed wording looks fine to me
  • Someone will eventually point out any inconsistencies between manual and desktop, so we should only change one if we plan to change the other
  • Creating new string with -2 will invalidate the existing translations, so they'll revert to English until a translator has a chance to translate them again. Has the English meaning changed enough that we need to force the translators to retranslate?

@brishtibheja
Copy link
Contributor

I am not so sure now. If a brght line distinction is made between them, one behaviour would be less intuitive: the on-screen timer stops at Maximum answer seconds. There seems to be some connection between them so they're not completely distinct, are they?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants