Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable adapter tests and disable broken Elasticsearch tests #386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cianmce
Copy link
Contributor

@cianmce cianmce commented Feb 23, 2022

  • include tests by updating pattern
  • add MySQL to be included during tests
  • skip broken Elasticsearch tests

I also tried adding ankane/setup-elasticsearch but that failed with the following error:

The client is unable to verify that the server is Elasticsearch. Some functionality may not be compatible if the server is running an unsupported product.
The client is unable to verify that the server is Elasticsearch. Some functionality may not be compatible if the server is running an unsupported product.
.......E

Error:
ElasticsearchTest#test_tables:
Elasticsearch::UnsupportedProductError: The client noticed that the server is not Elasticsearch and we do not support this unknown product.
    /home/runner/work/blazer/blazer/vendor/bundle/ruby/3.1.0/gems/elasticsearch-8.0.0/lib/elasticsearch.rb:1[15](https://github.com/cianmce/blazer/runs/5305254255?check_suite_focus=true#step:7:15):in `verify_with_version_or_header'
    /home/runner/work/blazer/blazer/vendor/bundle/ruby/3.1.0/gems/elasticsearch-8.0.0/lib/elasticsearch.rb:104:in `verify_elasticsearch'
    /home/runner/work/blazer/blazer/vendor/bundle/ruby/3.1.0/gems/elasticsearch-8.0.0/lib/elasticsearch.rb:70:in `method_missing'
    /home/runner/work/blazer/blazer/vendor/bundle/ruby/3.1.0/gems/elasticsearch-api-8.0.0/lib/elasticsearch/api/namespace/common.rb:38:in `perform_request'
    /home/runner/work/blazer/blazer/vendor/bundle/ruby/3.1.0/gems/elasticsearch-api-8.0.0/lib/elasticsearch/api/actions/cat/indices.rb:60:in `indices'
    /home/runner/work/blazer/blazer/lib/blazer/adapters/elasticsearch_adapter.rb:30:in `tables'
    /opt/hostedtoolcache/Ruby/3.1.1/x64/lib/ruby/3.1.0/forwardable.rb:238:in `tables'
    /home/runner/work/blazer/blazer/app/controllers/blazer/queries_controller.rb:[20](https://github.com/cianmce/blazer/runs/5305254255?check_suite_focus=true#step:7:20)0:in `tables'
    /home/runner/work/blazer/blazer/vendor/bundle/ruby/3.1.0/gems/actionpack-7.0.2.2/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant