Added name validation to query & dashboard #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pandu-49, thanks for another PR! I like the idea. It should probably only run the uniqueness validation when the name changes, so existing queries and dashboards that have duplicate names won't be affected. Also, an empty string in the name of query indicates a private query, so it'll need to support that. Let's keep the validations inline for each of the models, even if there's a small bit of duplication. |
|
@ankane Thanks for the response. Could you explain me more about private queries? Any example! Are these are storing into database from any other place? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added presence and uniqueness validation to queries and dashboards. Uniqueness validation score creator_id so that a user can have unique name which makes easy to identify and it avoids confusion.