serial/pci_16550: make sure that interrupts are disabled during init

Make sure that interrups are disabled during initialization. This is a proper fix for an unexpected MSI interrupt for PCI serial driver. Signed-off-by: p-szafonimateusz <[email protected]>
anjiahao1 · Oct 8, 2024 · da39a63 · da39a63
1 parent eea807f
commit da39a63
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/drivers/serial/uart_pci_16550.c b/drivers/serial/uart_pci_16550.c
@@ -595,14 +595,6 @@ static int pci_u16550_initialize(FAR struct pci_u16550_priv_s       *priv,
 
   priv->common.irq = pci_get_irq(dev);
 
-  /* Attach interrupts early to prevent unexpected isr fault */
-
-  ret = irq_attach(priv->common.irq, priv->common.ops->isr, dev);
-  if (ret != OK)
-    {
-      pcierr("Failed to attach irq %d\n", ret);
-    }
-
   return OK;
 }