feat: agent flow for proof presentation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
add-credo-flow
branch
3 times, most recently
from
d398720 to
a50320e
Compare
berendsliedrecht
commented
Oct 1, 2024
example/src/credo/bleRequestProof.ts
Outdated
| @@ -0,0 +1,164 @@ | |||
| import { | |||
There was a problem hiding this comment.
This is the main request proof functionality
berendsliedrecht
commented
Oct 1, 2024
example/src/credo/bleShareProof.ts
Outdated
| @@ -0,0 +1,200 @@ | |||
| import { | |||
There was a problem hiding this comment.
This is the main share proof functionality.
TimoGlastra
reviewed
Oct 2, 2024
Comment on lines
+19
to
+24
| const onFailure = () => console.error('[CENTRAL]: failure') | ||
| const onConnected = () => console.log('[CENTRAL]: connected') | ||
| const onDisconnected = () => console.log('[CENTRAL]: disconnected') |
There was a problem hiding this comment.
should we make the example a bit more in-depth? Would you usually do some reconnection stuff here?
There was a problem hiding this comment.
Really depends on the flow. I see them more as like UI update items. they are not too relevant.
example/src/credo/CredoScreen.tsx
Outdated
Comment on lines
19
to
21
| useEffect(() => { | ||
| setupAgent().then(setAgent) | ||
| }, []) |
There was a problem hiding this comment.
I've had issues with this in past, where setupAgent was called multiple times. I think we should handle it with state, or we can make it a useSetupAgent hook, which handles it with state internally ( and returns the agent afterwards ).
I know it's an example, but good to make the example follow best practices
example/src/credo/bleRequestProof.ts
Outdated
| }) | ||
| }) | ||
|
|
||
| const disconnctedNotifier = (agent: AppAgent, peripheral: Peripheral, onDisconnected: () => Promise<void> | void) => { |
There was a problem hiding this comment.
Suggested change
| const disconnctedNotifier = (agent: AppAgent, peripheral: Peripheral, onDisconnected: () => Promise<void> | void) => { | |
| const disconnectedNotifier = (agent: AppAgent, peripheral: Peripheral, onDisconnected: () => Promise<void> | void) => { |
example/src/credo/bleRequestProof.ts
Outdated
Comment on lines
148
to
155
| if (proofRecord.id === id) { | ||
| if (proofRecord.state === ProofState.PresentationReceived) { | ||
| const pp = agent.proofs.config.proofProtocols.find((x) => x.version === 'v2') | ||
| const { message } = await pp.acceptPresentation(agent.context, { proofRecord }) | ||
| const serializedMessage = JsonTransformer.serialize(message) | ||
| await peripheral.sendMessage(serializedMessage) | ||
| off() | ||
| resolve(proofRecord) | ||
| } else if ([ProofState.Abandoned, ProofState.Declined].includes(proofRecord.state)) { | ||
| off() | ||
| reject(new Error(`Proof could not be shared because it has been ${proofRecord.state}`)) | ||
| } | ||
| } |
There was a problem hiding this comment.
nit but usually if (proofRecord.id !==) return looks cleaner
| @@ -0,0 +1,109 @@ | |||
| // import { | |||
Comment on lines
27
to
32
| const formatData = await agent.proofs.getFormatData(proofRecord.id) | ||
| const proofRepository = agent.dependencyManager.resolve(ProofRepository) | ||
| proofRecord.metadata.set(METADATA_KEY_FORMAT_DATA, formatData) | ||
| await proofRepository.update(agent.context, proofRecord) | ||
| agent.events.off(ProofEventTypes.ProofStateChanged, listener) | ||
| resolve(proofRecord) |
There was a problem hiding this comment.
do we need this for the example?
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
add-credo-flow
branch
from
71a1c77 to
3b13e01
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
add-credo-flow
branch
from
8ce2174 to
1ba4b24
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
TimoGlastra
approved these changes
Oct 3, 2024
TimoGlastra
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berend Sliedrecht [email protected]