feat: Added support for url query inside the didcomm deeplink #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Lanser <[email protected]>
Tommylans
force-pushed
the
feature/didcomm-deeplinking-url-query
branch
from
0169a6e to
3346151
Compare
TimoGlastra
reviewed
Oct 27, 2023
packages/agent/src/parsers.ts
Outdated
| @@ -346,12 +347,15 @@ export async function tryParseDidCommInvitation( | |||
| invitationUrl: string | |||
| ): Promise<OutOfBandInvitation | null> { | |||
| try { | |||
| const parsedUrl = queryString.parseUrl(invitationUrl) | |||
| const updatedInvitationUrl = (parsedUrl['url'] as string | undefined) ?? invitationUrl | |||
There was a problem hiding this comment.
I think we should maybe call this oobUrl=?
BTW. For the deeplink in Paradym, we can just use https://paradym.id right, as we link to our own wallet?
So if the button says Open in Paradym Wallet, we don't really need the didcomm:// prefix?
Ofc. Good for other wallets
There was a problem hiding this comment.
I'll update it, so it will work with the didcomm://?oobUrl= deeplink the https deeplinking needs a bit more work.
Signed-off-by: Tom Lanser <[email protected]>
TimoGlastra
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested yet.