Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to expo 49 #69

Merged
merged 1 commit into from
Sep 28, 2023
Merged

chore: update to expo 49 #69

merged 1 commit into from
Sep 28, 2023

Conversation

TimoGlastra
Copy link
Member

Updates expo to 49. Mainly to get the new debugging support

Signed-off-by: Timo Glastra <[email protected]>
"prettier": "prettier --ignore-path .gitignore '**/*.+(js|jsx|json|ts|tsx|md|yml|yaml)'",
"format": "yarn prettier --write",
"check-format": "yarn prettier --list-different",
"_prettier": "prettier --ignore-path .gitignore '**/*.+(js|jsx|json|ts|tsx|md|yml|yaml)'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this done?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a suggestion from expo doctor because the scripts was the same as the binary. So it'd override the behvaiour of yarn prettier (which would normally execute the binary)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I did not know that yarn prettier picks the binary. Is this a v3 thing? I do think that _prettier will be forgotten to be used and yarn prettier will be ran. But then again it likely yarn format and yarn check-format will be used most.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yarn _prettier is not meant to be used. It's to make the other two commands not duplicate the base part of the query. So I'm not too worried about this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I did not know that yarn prettier picks the binary. Is this a v3 thing?

No I think that's a yarn thing in general.

@TimoGlastra TimoGlastra merged commit 21f13dd into main Sep 28, 2023
1 check passed
@TimoGlastra TimoGlastra deleted the chore/update-expo branch September 28, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants