feat: dcql and a lot of UI stuff #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
janrtvld
approved these changes
Nov 25, 2024
| @@ -132,6 +139,12 @@ export function FunkeCredentialNotificationScreen() { | |||
| [agent] | |||
| ) | |||
|
|
|||
| // TODO: Should we add this to the activitiy? We also don't do it for issuance | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Okay. Reason for the comment is that i see this more as a failed issuance. But yeah if that's also on the list.
We don't support failed issuance though? And just adding this as failed proof request is weird i think as it's during issuance
| // We only have the attribute paths, no way to know how to render | ||
| // TODO: we could look at the vct? | ||
| // TODO: we should maybe support partial matches (i.e. vct matches), as then we can | ||
| // show a much better UI (you have the cred, but age is not valid, or this param is missing) |
There was a problem hiding this comment.
Do you mean then rendering the credential card but with 'date_of_birth' in red when it doesn't match the required age?
| @@ -67,7 +76,7 @@ export class ReceivePidUseCaseCFlow extends ReceivePidUseCaseFlow { | |||
| resolvedCredentialOffer: this.resolvedCredentialOffer, | |||
| credentialConfigurationIdsToRequest, | |||
| clientId: ReceivePidUseCaseCFlow.CLIENT_ID, | |||
| requestBatch: getShouldUseCloudHsm() ? 10 : false, | |||
| requestBatch: getShouldUseCloudHsm() ? 2 : false, | |||
There was a problem hiding this comment.
Need to update WSP. It doesn't batch soo is way too slow at 10
| @@ -93,7 +94,7 @@ export class RefreshPidUseCase { | |||
| resolvedCredentialOffer: this.resolvedCredentialOffer, | |||
| credentialConfigurationIdsToRequest, | |||
| clientId: RefreshPidUseCase.CLIENT_ID, | |||
| requestBatch: 10, | |||
| requestBatch: 2, | |||
Signed-off-by: Timo Glastra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR grew a lot bigger than anticipated but it hasA LOT of great improvements: