feat: pid flow in wallet #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan <[email protected]>
TimoGlastra
reviewed
Nov 16, 2024
TimoGlastra
reviewed
Nov 16, 2024
TimoGlastra
requested changes
Nov 16, 2024
There was a problem hiding this comment.
To me this duplication doesn't make sense, and the reason being the complexity makes less sense. I think we just made it 2x as complex by dupilcating the code. Everything now needs to be changed in two places.
I think the correct way would be to create a better abstraction. So we can at least reuse the views and logic, but still have control over what is different.
At least we should have the screens as separate components
TimoGlastra
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to re-use some screens but i've copied over a lot of the logic because it's hard to understand code and some things just work a bit different if you already have a wallet. So to not make the logic in the onboarding even more unreadable i just did it like this.
TODOs