Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lifecycle states #206
feat: lifecycle states #206
Changes from all commits
603aba5
8118709
64b7718
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will never render if validFrom/until is defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because if the many variants I moved that to a different component. (see line 69).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i asked about refresh and they recommended me to use the C" issuance flow which does support refresh tokens.
So the flow would be:
But this will be a lot better already. So i think the "only x left in batch" should only be shown if we werent't able to automatically get new ones and re-authentication is required. But that's really a fallback.
We have the ReceivePidUseCaseFlow. Maybe if you can add these placeholder methods for now I'll implement these later:
Then if that method fails because of unauthorized we need to trigger eID flow, or at least show to the user that they only have X verifications left and they need to re-authenticate.