feat(mdoc): proximity flow for Android functionality #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
approved these changes
Nov 5, 2024
| agent: EasyPIDAppAgent | ||
| } | ||
|
|
||
| export const shareDeviceResponse = async (options: ShareDeviceResponseOptions) => { |
Comment on lines
16
to
25
| const issuerSignedDocuments = mdocs.map((mdoc) => { | ||
| const docType = mdoc.getTag('DocType') as string | ||
| return parseIssuerSigned(TypedArrayEncoder.fromBase64(mdoc.base64Url), docType) | ||
| }) |
There was a problem hiding this comment.
Can we do a pre-selection on the doctype? So we don't have to fetch all docs? I think the device request should contain some filters?
berendsliedrecht
force-pushed
the
android-mdoc-proximity
branch
from
e91e187 to
d676c72
Compare
berendsliedrecht
force-pushed
the
android-mdoc-proximity
branch
2 times, most recently
from
2d3f73e to
189d0d3
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
android-mdoc-proximity
branch
from
189d0d3 to
ddad4b0
Compare
added 3 commits
November 19, 2024 11:49
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berend Sliedrecht [email protected]