feat: credential selection in proof request #113
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
|
As you can see in the last commit, I disabled it for now in the UI. We can enable it again soon when we reworked the UX / design for selecting a credential |
| }} | ||
| // The index is stable enough here | ||
| // biome-ignore lint/suspicious/noArrayIndexKey: <explanation> | ||
| key={credentialIndex} |
There was a problem hiding this comment.
Does the credential not have an id we can use? I learned my lesson a few weeks back when debugging an index used as a key for way too long.
There was a problem hiding this comment.
I think we can add it. But we don't have it right now in this model. But yeah no reason to not use the id
packages/ui/src/panels/Sheet.tsx
Outdated
There was a problem hiding this comment.
What was wrong with the tamagui sheet?
There was a problem hiding this comment.
It was a year ago that I implemented this so ... TBH I don't know anymore. I can vaguely remember that It was just buggy and I've had good experience with this sheet (as it's rendered as native sheet on iOS)
There was a problem hiding this comment.
I think it had to do also with scroll. If you have a lot of credentials, it will become a scroll the sheet, which also didn't work very well with the tamagui sheet (if i remember correctly)
|
@TimoGlastra do you need an additional review on this? |
|
No it's ok 👍 |
Signed-off-by: Timo Glastra <[email protected]>
|
I've updated this with the grouping, but have improved upon it a bit. We prefer grouping by CREDENTIAL, as it's what we use in Paradym and otherwise if all the matches for a requested entry match. In most cases I think this should suffice. And we will filter the matches so it correctly shows the options if selection is enabled that can be used for all credentials in the group. There is one case that is not catched by this, and this is when you request a predicate and values from the same credential basically, but without the CREDENTIAL prefix in group name. This can gives multiple separate optoins ,but I feel this is more a limitation of AnonCreds proof requests, which we have now sovled using the CREDENTIAL prefix There has been some pushback on adding this feature to AnonCreds v1, so I think our 'workaround' is fine here. hyperledger/anoncreds-rs#292 |
|
Adding a "received on XXX" will probably already help a lot with being able to distinguish credentials when selecting |
Signed-off-by: Timo Glastra <[email protected]>
This supersedes #71 and adds credential selection. It's a bit meh as you can't really see the credential you're selection.
So I had two potential ideas:
Works with both DIDComm and OpenID4VC.
@berendsliedrecht @janrtvld WDYT?
RPReplay_Final1719332123.MP4