Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(funke): initialized new wallet and agent setup #111

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

berendsliedrecht
Copy link
Member

Signed-off-by: Berend Sliedrecht [email protected]

Copy link
Member

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably move more out of the app, now is the easiest time to do it i think as there's no duplication yet

@berendsliedrecht
Copy link
Member Author

berendsliedrecht commented Jun 10, 2024

We can probably move more out of the app, now is the easiest time to do it i think as there's no duplication yet

What do you mean exactly?

edit: ahh, I understand. I'll see if I can move some of the UI views as well.

@berendsliedrecht berendsliedrecht force-pushed the funke-new-wallet branch 3 times, most recently from fdaf94c to f91747c Compare June 11, 2024 15:37
Signed-off-by: Berend Sliedrecht <[email protected]>
initialRouteName: 'index',
}

export default function HomeLayout() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feel we can improve on duplication here (e.g. with fonts, initialization, hooks). But let's merge now and we can look at it later if needed. Good chance we can all throw it away in a few months anyway 🤷

@@ -1,9 +1,10 @@
import { useCallback } from 'react'
import type { ReactNode } from 'react'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one we can also move?


const deeplinkSchemes = Object.values(InvitationQrTypes)

export const DeeplinkHandler = ({ children }: DeeplinkHandlerProps) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated between apps

"@hyperledger/aries-askar-react-native": "*",
"@hyperledger/indy-vdr-react-native": "*"
}
"name": "@package/agent",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why @Package over @internal?

Fine but never seen @Package before

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@package is what we use for idcrypt.

@berendsliedrecht berendsliedrecht merged commit 4dec778 into main Jun 12, 2024
1 check passed
@berendsliedrecht berendsliedrecht deleted the funke-new-wallet branch June 12, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants