-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(funke): initialized new wallet and agent setup #111
Conversation
f2f7695
to
55e3c16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably move more out of the app, now is the easiest time to do it i think as there's no duplication yet
What do you mean exactly? edit: ahh, I understand. I'll see if I can move some of the UI views as well. |
Signed-off-by: Berend Sliedrecht <[email protected]>
fdaf94c
to
f91747c
Compare
Signed-off-by: Berend Sliedrecht <[email protected]>
f91747c
to
b1f08c3
Compare
initialRouteName: 'index', | ||
} | ||
|
||
export default function HomeLayout() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still feel we can improve on duplication here (e.g. with fonts, initialization, hooks). But let's merge now and we can look at it later if needed. Good chance we can all throw it away in a few months anyway 🤷
@@ -1,9 +1,10 @@ | |||
import { useCallback } from 'react' | |||
import type { ReactNode } from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one we can also move?
|
||
const deeplinkSchemes = Object.values(InvitationQrTypes) | ||
|
||
export const DeeplinkHandler = ({ children }: DeeplinkHandlerProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated between apps
"@hyperledger/aries-askar-react-native": "*", | ||
"@hyperledger/indy-vdr-react-native": "*" | ||
} | ||
"name": "@package/agent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@package
is what we use for idcrypt.
Signed-off-by: Berend Sliedrecht [email protected]