Args validation checks #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation check for duplicate arguments
Add test for error message thrown by animint()
tdhock
requested changes
Jan 29, 2024
R/z_print.R
Outdated
| duplicate_args <- names(L)[duplicated(names(L))] | ||
|
|
||
| if (length(duplicate_args) > 0) { | ||
| stop(paste("Error: Duplicate arguments are passed to animint. Duplicate arguments found :", |
There was a problem hiding this comment.
looks like a good start thanks!
please remove Error: (that will show up anyway when you use stop) and please remove space before colon
"found :" -> "found:"
also next time can you please commit and push the test code so that we can see that it fails on github actions, before you push the code which makes the test pass?
There was a problem hiding this comment.
Updated the error message. Next time, I will push the test code first before pushing the code
|
I should have asked you to do that here before merging, but can you also in another PR please
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds validation check when duplicate names args are passed to animint
Closes #83