Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #445 and fix #424 download highest sub-patch chromedriver #447

Open
wants to merge 2 commits into
base: legacy
Choose a base branch
from
Open

fix #445 and fix #424 download highest sub-patch chromedriver #447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
887a553
fix #445 download highest sub-patch chromedriver
captaincaius Feb 26, 2020
1470e10
fix lint in chrome_xml
captaincaius Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/binaries/chrome_xml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,14 @@ export class ChromeXml extends XmlConfigSource {
// For 64-bit systems, prefer the 64-bit version.
else if (this.osarch === 'x64') {
if (item.includes(this.getOsTypeName() + '64')) {
itemFound = item;
// Only override the previously found item if its sub-patch-version is less
// than that of the current candidate.
const itemFoundVersionParts = itemFound.split('/')[0].split('.');
const versionParts = version.split('.');
if (itemFoundVersionParts.length < 4 ||
(parseInt(versionParts[3] || '0') > parseInt(itemFoundVersionParts[3]))) {
itemFound = item;
}
}
}
}
Expand Down