Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting specific chromedriver version ignores patch number #424

Open
TravkinAlex opened this issue Sep 17, 2019 · 3 comments · May be fixed by #413
Open

Getting specific chromedriver version ignores patch number #424

TravkinAlex opened this issue Sep 17, 2019 · 3 comments · May be fixed by #413

Comments

@TravkinAlex
Copy link

TravkinAlex commented Sep 17, 2019

As partially described in #408, patch version gets ignored for chromedriver;
this has been fixed for getting LATEST version, but for getting the SPECIFIC version the issue is still relevant. relevant for both since getting latest still uses the same method
[13:04:17] I/downloader - curl -oD:\BillfoldRepos\webdriver-manager\selenium/chromedriver_76.0.3809.68.zip https://chromedriver.storage.googleapis.com/76.0.3809.12/chromedriver_win32.zip
before fix

Steps to reproduce:

  1. Use webdriver-manager 12.1.7 (currently latest)
  2. Run webdriver-manager update --versions.chrome=76.0.3809.68
  3. Actual result - download is from URL https://chromedriver.storage.googleapis.com/76.0.3809.12/chromedriver_win32.zip, actual chromedriver downloaded is 76.0.3809.12, the binary file then gets renamed (?) to 76.0.3809.68.

I've submitted a fix in #413 .

Seems like a related issue - #401 .

@TravkinAlex TravkinAlex linked a pull request Sep 17, 2019 that will close this issue
@VadimSkuratovskyi
Copy link

VadimSkuratovskyi commented Sep 20, 2019

Faced with the same issue, trying to install the latest 76 version of chromeDriver-76.0.3809.126 for the Chrome-v76 using latest webdriver-manager 12.1.7
webdriver-manager update --versions.chrome=76.0.3809.128
but downloaded --chromeDriver - v76.0.3809.12 and receiving next in console:
(\node_modules\webdriver-manager\selenium/chromedriver_76.0.3809.128.zip https://chromedriver.storage.googleapis.com/76.0.3809.12/chromedriver_win32.zip)
Could anyone please take a look at this pull request?
@cnishina I hope you can help us to fix this issue.

@captaincaius
Copy link

Doh! Sorry for the duplicated effort but I made #447 before realizing the other PR existed ...

@captaincaius
Copy link

PS technically it's not the patch number, but one level below it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants