Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webdriver-manager version 12.1.7 Issue when downloading latest 78 version chromedriver #432

Open
gemelgb opened this issue Oct 30, 2019 · 1 comment

Comments

@gemelgb
Copy link

gemelgb commented Oct 30, 2019

Command webdriver-manager update --gecko=false

Downloads 78.0.3904.11/chromedriver_win32.zip rather than 78.0.3904.70/chromedriver_win32.zip.

Bug in the code chrome_xml.ts:

Method name: getSpecificChromeDriverVersion

if (itemFound == '') {
if (this.osarch === 'x64' ||
(this.osarch !== 'x64' && !item.includes(this.getOsTypeName() + '64'))) {
itemFound = item;
console.log(this.osarch + " item registered chromedriver--->" + itemFound);
}
}
else if (this.osarch === 'x64') {
if (item.includes(this.getOsTypeName() + '64')) {
itemFound = item;
console.log(this.osarch + " item registered chromedriver--->" + itemFound);
}
}
Since the else if can never be satisfied (since chrome driver will never deliver a win64 version you would need to adjust the code to:

else if (this.osarch === 'x64') {
if (item.includes(this.getOsTypeName() + '64') || (item.includes(this.getOsTypeName() + '32') && this.getOsTypeName() == 'win')) {

Include a or '32' which is the case so the latest 78.0.3904.70/chromedriver_win32.zip can be downloaded!

If you want I can open a PR for you??

BR
Georgios

@TravkinAlex
Copy link

From the description of the problem it looks like the long standing issue which is mentioned here among other places #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants