Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new pull request by comparing changes across two branches #249

Merged
merged 12 commits into from
Jan 8, 2025
Merged

Create a new pull request by comparing changes across two branches #249

merged 12 commits into from
Jan 8, 2025

Conversation

GulajavaMinistudio
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

devversion and others added 12 commits January 7, 2025 15:31
@devversion @thePunderWoman
ci: remove devversion from unavailable pullapprove list (#59391)
97039e8 
Removing myself as I'm available for reviews.

PR Close #59391
@angular-robot @thePunderWoman
build: update dependency @types/diff to v7 (#59403)
adc56b7 
See associated pull request for more information.

PR Close #59403
@arturovt @thePunderWoman
refactor(docs-infra): cleanup after render sequence in `ReferenceScro…
dc07a43 
…llHandler` (#58640)

In this commit, we're replacing the provided injector in `afterNextRender` with a node injector
because it was previously mistakenly passing an `EnvironmentInjector` in the `ReferenceScrollHandler`.

PR Close #58640
@pkozlowski-opensource @thePunderWoman
refactor(docs-infra): code cleanups (#59395)
e1ab001 
A handfull of different code cleanups in adev
components.

PR Close #59395
@angular-robot @thePunderWoman
build: update dependency @types/selenium-webdriver4 to v4.1.28 (#59389)
d1f8834 
See associated pull request for more information.

PR Close #59389
@crisbeto @thePunderWoman
fix(platform-browser): styles not replaced during HMR when using anim…
0e23f20 
…ations renderer (#59393)

When we replace a component during HMR, we clear it from the cache of the renderer factory, however when using animations, there's an animation-specific renderer factory that wraps the base DOM one and was preventing the cache from being cleared.

These changes rework the logic that clear the cache to go through a method so we can forward the call to the delegated factory.

PR Close #59393
@johnsoncodehk @thePunderWoman
refactor: remove unnecessary TSLint rule flags (#59365)
a6cdbec 
There are many TSLint rule flags in the source code that have no effect, and they can be safely removed to keep the code clean.

PR Close #59365
@johnsoncodehk @thePunderWoman
refactor: remove unnecessary // tslint:disable rule flags in devtoo…
9b8f699 
…ls (#59365)

Files in the vendor directory have been excluded in tslint.json.

PR Close #59365
@JeanMeche @thePunderWoman
refactor(core): remove outdated comment. (#59401)
aaf1fbb 
Should have been done by #58238, but was probably missed in a rebase.

fixes #59397

PR Close #59401
@arturovt @thePunderWoman
refactor(core): prevent duplicating LView destroyed checks (#59387)
5685b4c 
The `type_checks` module already exposes a utility function that checks whether `LView` is marked
as destroyed. There is no need to check flags in other places, as we can reuse the helper function.

PR Close #59387
@arturovt @thePunderWoman
fix(router): complete router events on dispose (#59327)
52a6710 
In this commit, we manually complete the `events` subject to remove all active observers and enable
granular garbage collection, as users may forget to unsubscribe manually when subscribing to `router.events`.

PR Close #59327
@arturovt @thePunderWoman
refactor(core): drop DEFER_BLOCK_DEPENDENCY_INTERCEPTOR in producti…
d9707e1 
…on (#59381)

`new` expressions are not dropped by default because they are considered side-effectful,
even if they are not referenced anywhere in production mode.

PR Close #59381
@GulajavaMinistudio GulajavaMinistudio merged commit 33a5b84 into angular-indonesia:main Jan 8, 2025
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GulajavaMinistudio @devversion @angular-robot @arturovt @pkozlowski-opensource @crisbeto @johnsoncodehk @JeanMeche