Custom Multi Chain Cosmwasm Client, CLI Wallet command enhancement, CLI Multi Env, and bug fixes #117
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (19)
You can disable this status message by setting the WalkthroughThe changes include the introduction of a new configuration file for managing review processes, updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant ReviewSystem
participant Codebase
Developer->>ReviewSystem: Submit changes for review
ReviewSystem->>Codebase: Apply path filters
Codebase-->>ReviewSystem: Return relevant changes
ReviewSystem-->>Developer: Provide review results
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 40
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (34)
- package.json (1 hunks)
- packages/adocodegen/package.json (1 hunks)
- packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.client.ts (1 hunks)
- packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.types.ts (1 hunks)
- packages/adocodegen/src/adodb/1.0.0/AdodbContractTs.client.ts (1 hunks)
- packages/adocodegen/src/adodb/1.0.0/AdodbContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/adodb/1.0.0/AdodbContractTs.types.ts (1 hunks)
- packages/adocodegen/src/app-contract/1.0.0/AppContractContractTs.client.ts (1 hunks)
- packages/adocodegen/src/app-contract/1.0.0/AppContractContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/app-contract/1.0.0/AppContractContractTs.types.ts (1 hunks)
- packages/adocodegen/src/app-contract/1.0.1/AppContractContractTs.client.ts (1 hunks)
- packages/adocodegen/src/app-contract/1.0.1/AppContractContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/app-contract/1.0.1/AppContractContractTs.types.ts (1 hunks)
- packages/adocodegen/src/auction/1.0.0/AuctionContractTs.client.ts (1 hunks)
- packages/adocodegen/src/auction/1.0.0/AuctionContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/auction/1.0.0/AuctionContractTs.types.ts (1 hunks)
- packages/adocodegen/src/cross-chain-swap/1.0.0/CrossChainSwapContractTs.client.ts (1 hunks)
- packages/adocodegen/src/cross-chain-swap/1.0.0/CrossChainSwapContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/cross-chain-swap/1.0.0/CrossChainSwapContractTs.types.ts (1 hunks)
- packages/adocodegen/src/crowdfund/1.0.0/CrowdfundContractTs.client.ts (1 hunks)
- packages/adocodegen/src/crowdfund/1.0.0/CrowdfundContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/crowdfund/1.0.0/CrowdfundContractTs.types.ts (1 hunks)
- packages/adocodegen/src/cw20-exchange/1.0.0/Cw20ExchangeContractTs.client.ts (1 hunks)
- packages/adocodegen/src/cw20-exchange/1.0.0/Cw20ExchangeContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/cw20-exchange/1.0.0/Cw20ExchangeContractTs.types.ts (1 hunks)
- packages/adocodegen/src/cw20-staking/1.0.0/Cw20StakingContractTs.client.ts (1 hunks)
- packages/adocodegen/src/cw20-staking/1.0.0/Cw20StakingContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/cw20-staking/1.0.0/Cw20StakingContractTs.types.ts (1 hunks)
- packages/adocodegen/src/cw20/1.0.0/Cw20ContractTs.client.ts (1 hunks)
- packages/adocodegen/src/cw20/1.0.0/Cw20ContractTs.message-builder.ts (1 hunks)
- packages/adocodegen/src/cw20/1.0.0/Cw20ContractTs.types.ts (1 hunks)
- packages/adocodegen/src/cw721/1.0.0/Cw721ContractTs.client.ts (1 hunks)
- packages/adocodegen/src/cw721/1.0.0/Cw721ContractTs.message-builder.ts (1 hunks)
Additional context used
Biome
packages/adocodegen/src/adodb/1.0.0/AdodbContractTs.types.ts
[error] 95-95: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 97-97: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 99-99: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 101-101: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/cross-chain-swap/1.0.0/CrossChainSwapContractTs.message-builder.ts
[error] 9-82: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 83-149: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/cross-chain-swap/1.0.0/CrossChainSwapContractTs.types.ts
[error] 35-35: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 122-122: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 124-124: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 126-126: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 128-128: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 130-130: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 132-132: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 134-134: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 136-136: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 138-138: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 146-146: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.types.ts
[error] 117-117: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 119-119: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 121-121: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 123-123: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 125-125: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 127-127: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 129-129: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 131-131: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 133-133: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 141-141: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.message-builder.ts
[error] 7-7: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 9-88: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 89-171: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/app-contract/1.0.0/AppContractContractTs.types.ts
[error] 50-50: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 142-142: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 148-148: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 150-150: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 152-152: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 154-154: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 156-156: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 158-158: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 160-160: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 162-162: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 164-164: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 166-166: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 174-174: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/app-contract/1.0.1/AppContractContractTs.types.ts
[error] 50-50: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 142-142: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 148-148: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 150-150: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 152-152: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 154-154: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 156-156: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 158-158: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 160-160: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 162-162: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 164-164: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 166-166: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 174-174: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/cw20-exchange/1.0.0/Cw20ExchangeContractTs.types.ts
[error] 131-131: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 138-138: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 140-140: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 142-142: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 144-144: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 146-146: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 148-148: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 150-150: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 152-152: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 160-160: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 193-193: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/cw20-exchange/1.0.0/Cw20ExchangeContractTs.message-builder.ts
[error] 9-92: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 93-183: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/adodb/1.0.0/AdodbContractTs.message-builder.ts
[error] 9-86: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 87-206: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/app-contract/1.0.0/AppContractContractTs.message-builder.ts
[error] 7-7: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 7-7: Do not shadow the global "String" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 9-110: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 111-209: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/app-contract/1.0.1/AppContractContractTs.message-builder.ts
[error] 7-7: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 7-7: Do not shadow the global "String" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 9-110: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 111-209: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/cw20-staking/1.0.0/Cw20StakingContractTs.types.ts
[error] 50-50: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 160-160: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 162-162: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 173-173: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 175-175: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 177-177: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 179-179: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 181-181: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 183-183: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 185-185: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 187-187: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 195-195: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 201-201: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/crowdfund/1.0.0/CrowdfundContractTs.types.ts
[error] 44-44: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 165-165: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 167-167: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 178-178: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 180-180: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 182-182: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 184-184: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 186-186: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 188-188: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 190-190: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 192-192: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 200-200: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 206-206: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 244-244: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/cw20-staking/1.0.0/Cw20StakingContractTs.message-builder.ts
[error] 9-143: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 144-255: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/crowdfund/1.0.0/CrowdfundContractTs.message-builder.ts
[error] 7-7: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 9-165: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 166-277: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/auction/1.0.0/AuctionContractTs.types.ts
[error] 225-225: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 227-227: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 229-229: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 231-231: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 233-233: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 235-235: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 237-237: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 239-239: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 247-247: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 253-253: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 272-272: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/cw20/1.0.0/Cw20ContractTs.types.ts
[error] 141-141: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 216-216: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 218-218: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 236-236: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 238-238: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 244-244: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 246-246: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 248-248: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 250-250: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 252-252: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 254-254: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 256-256: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 258-258: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 266-266: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
[error] 272-272: Don't use '{}' as a type.
Prefer explicitly define the object shape. '{}' means "any non-nullable value".
(lint/complexity/noBannedTypes)
packages/adocodegen/src/cw20/1.0.0/Cw20ContractTs.message-builder.ts
[error] 9-237: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 238-387: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.client.ts
[error] 9-9: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
packages/adocodegen/src/auction/1.0.0/AuctionContractTs.message-builder.ts
[error] 7-7: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 9-210: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 211-411: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/cw721/1.0.0/Cw721ContractTs.message-builder.ts
[error] 7-7: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 9-233: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
[error] 234-458: Avoid classes that contain only static members.
Prefer using simple functions instead of classes with only static members.
(lint/complexity/noStaticOnlyClass)
packages/adocodegen/src/app-contract/1.0.0/AppContractContractTs.client.ts
[error] 9-9: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 9-9: Do not shadow the global "String" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
packages/adocodegen/src/app-contract/1.0.1/AppContractContractTs.client.ts
[error] 9-9: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
[error] 9-9: Do not shadow the global "String" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
packages/adocodegen/src/crowdfund/1.0.0/CrowdfundContractTs.client.ts
[error] 9-9: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
packages/adocodegen/src/auction/1.0.0/AuctionContractTs.client.ts
[error] 9-9: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
packages/adocodegen/src/cw721/1.0.0/Cw721ContractTs.client.ts
[error] 9-9: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
Additional comments not posted (30)
packages/adocodegen/package.json (4)
9-11: Approved: New build script.The addition of the
buildscript to clean the./distdirectory before compiling TypeScript files is a good practice to ensure a clean build environment.
16-16: Approved: Update to files array.Changing the
filesarray to include./distinstead of./srcensures that the distribution files are included in the package, which is appropriate for a TypeScript project where the source files are compiled.
23-26: Approved: Addition of new peer dependencies.Adding
@cosmjs/cosmwasm-stargate,@cosmjs/amino, andtype-festas peer dependencies is appropriate to ensure compatibility and proper functioning of the package with these libraries.
9-11: Verify: Removal of exports field.The removal of the
exportsfield may affect how the package is consumed. It's important to verify that this change does not disrupt existing module resolution and imports in dependent projects.Verification successful
No impact from removal of exports field.
The removal of the
exportsfield from thepackage.jsondoes not appear to affect the codebase, as no imports of theadocodegenpackage were found. This suggests that the package is not being used elsewhere in the repository.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing the exports field on module resolution. # Test: Search for imports of the adocodegen package in the repository. Expect: No unresolved imports. rg --type json -A 5 $'import .*adocodegen'Length of output: 43
Script:
#!/bin/bash # Description: Verify the impact of removing the exports field on module resolution. # Test: Search for imports of the adocodegen package across all file types in the repository. rg 'import .*adocodegen' -A 5Length of output: 31
package.json (3)
11-11: Approved: Clarified path in collect script.The modification to specify the path as
./local_libsin thecollectscript clarifies the target directory, which is a good practice for maintainability and avoiding potential path resolution issues.
18-18: Approved: Updated version of @changesets/cli.Updating the
@changesets/clidependency to version^2.27.8ensures that the project uses the latest compatible version, potentially incorporating bug fixes and new features.
20-20: Approved: Updated version of rimraf.Updating the
rimrafdependency to version^4.4.1ensures that the project uses the latest compatible version, potentially incorporating bug fixes and new features.packages/adocodegen/src/adodb/1.0.0/AdodbContractTs.client.ts (1)
1-358: File review completed.The
AdodbContractTs.client.tsfile is well-structured and aligns with its intended functionality. No specific changes or improvements are necessary at this time.packages/adocodegen/src/cw20-exchange/1.0.0/Cw20ExchangeContractTs.client.ts (4)
10-43: Interface Definition Review:Cw20ExchangeContractTsReadOnlyInterfaceThe interface is well-defined with clear method signatures that match the expected functionalities for querying contract states. Each method returns a promise, which is appropriate for asynchronous operations.
44-158: Class Implementation Review:Cw20ExchangeContractTsQueryClientThis class correctly implements the
Cw20ExchangeContractTsReadOnlyInterface. The constructor and method bindings are properly set up, ensuring thatthisreferences are maintained correctly in asynchronous methods. The use ofqueryContractSmartwithin each method is consistent and correctly formatted to match the expected contract queries.
159-200: Interface Definition Review:Cw20ExchangeContractTsInterfaceThe interface is correctly defined with methods that cover various contract operations such as
cancelSale,purchase, andreceive. Each method signature is clear and includes optional parameters for transaction customization, which is a good practice for flexibility in contract interactions.
201-304: Class Implementation Review:Cw20ExchangeContractTsClientThis class implements the
Cw20ExchangeContractTsInterfaceeffectively. The constructor properly initializes the class properties, and the method bindings ensure thatthisis correctly referenced in asynchronous operations. The use ofexecutewithin each method is appropriate for contract interactions, and the handling of default parameters likefeeset to"auto"provides good usability for contract function calls.packages/adocodegen/src/app-contract/1.0.0/AppContractContractTs.client.ts (2)
44-167: Approved: Implementation ofAppContractContractTsQueryClient.The class
AppContractContractTsQueryClientcorrectly implements the read-only interface and uses proper async/await syntax for making smart contract queries. The methods are bound correctly in the constructor, ensuringthiscontext is maintained.
218-342: Approved: Implementation ofAppContractContractTsClient.The class
AppContractContractTsClientimplements the interface for contract interactions that require signing. It properly handles the execution of contract functions with appropriate parameters and options. The use of async/await and binding in the constructor is correctly done.packages/adocodegen/src/app-contract/1.0.1/AppContractContractTs.client.ts (2)
44-167: Approved: Implementation ofAppContractContractTsQueryClient.The class
AppContractContractTsQueryClientin this version continues to correctly implement the read-only interface with proper async/await syntax for smart contract queries. The methods are appropriately bound in the constructor.
218-342: Approved: Implementation ofAppContractContractTsClient.The class
AppContractContractTsClientin this version maintains the correct implementation for contract interactions requiring signing. The execution of contract functions is handled properly with appropriate parameters and options.packages/adocodegen/src/cw20-staking/1.0.0/Cw20StakingContractTs.client.ts (2)
51-188: Approved: Implementation ofCw20StakingContractTsQueryClient.The class
Cw20StakingContractTsQueryClientcorrectly implements the read-only interface and uses proper async/await syntax for making smart contract queries. The methods are bound correctly in the constructor, ensuringthiscontext is maintained.
255-415: Approved: Implementation ofCw20StakingContractTsClient.The class
Cw20StakingContractTsClientimplements the interface for contract interactions that require signing. It properly handles the execution of contract functions with appropriate parameters and options. The use of async/await and binding in the constructor is correctly done.packages/adocodegen/src/crowdfund/1.0.0/CrowdfundContractTs.client.ts (1)
10-50: Interface Definition ApprovedThe
CrowdfundContractTsReadOnlyInterfaceis well-defined with clear method signatures and appropriate asynchronous patterns. Good use of TypeScript features for type safety and readability.packages/adocodegen/src/cw721/1.0.0/Cw721ContractTs.client.ts (3)
1-9: File Header and Imports ApprovedThe file header correctly warns against manual modifications, which is essential for auto-generated files. The imports are appropriate for the operations described within the file.
Tools
Biome
[error] 9-9: Do not shadow the global "Boolean" property.
Consider renaming this variable. It's easy to confuse the origin of variables when they're named after a known global.
(lint/suspicious/noShadowRestrictedNames)
112-381: Class Implementation ApprovedThe
Cw721ContractTsQueryClientclass is well-implemented. The methods are correctly bound in the constructor to ensure the properthiscontext, and the use ofqueryContractSmartfor blockchain interactions is appropriate.
500-765: Transactional Class Implementation ApprovedThe
Cw721ContractTsClientclass is correctly implemented for handling transactional interactions with the CW721 contract. The methods are comprehensive and use theexecutefunction appropriately for sending transactions.packages/adocodegen/src/cross-chain-swap/1.0.0/CrossChainSwapContractTs.types.ts (4)
7-7: Type Definitions ApprovedThe basic type definitions such as
Milliseconds,Decimal,AndrAddr,Binary,Uint128,Addr, andReplyOnare correctly implemented and serve as simple aliases for more complex types.Also applies to: 8-8, 9-9, 10-10, 52-52, 59-59, 51-51
11-16: InterfaceInstantiateMsgApprovedThe
InstantiateMsginterface is well-defined with appropriate types and optional properties, facilitating clear contract instantiation parameters.
60-89: InterfacesPermissioningMessageandPermissionApprovedThe
PermissioningMessageandPermissioninterfaces are well-structured and provide a comprehensive framework for managing permissions within the contract.
90-105: InterfacesAMPPkt,AMPCtx, andAMPMsgApprovedThese interfaces are correctly implemented, providing clear and structured definitions for handling AMP packets within the contract.
packages/adocodegen/src/cw20/1.0.0/Cw20ContractTs.client.ts (1)
73-96: Ensure proper binding of methods in constructor.The constructor of
Cw20ContractTsQueryClientbinds numerous methods to ensure they maintain the correct context when called. This is a good practice, especially in TypeScript, to avoid issues withthiskeyword losing context in callbacks.packages/adocodegen/src/auction/1.0.0/AuctionContractTs.client.ts (1)
110-134: Ensure proper binding of methods in constructor.The constructor of
AuctionContractTsQueryClientbinds numerous methods to ensure they maintain the correct context when called. This is a good practice, especially in TypeScript, to avoid issues withthiskeyword losing context in callbacks.packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.types.ts (1)
1-5: Header Comment: Do not modify by hand.The header comment clearly instructs not to modify the file by hand and to use the code generation tool instead. This is important for maintainability and ensuring that changes are made in the source JSONSchema and not directly in the TypeScript file.
packages/adocodegen/src/auction/1.0.0/AuctionContractTs.message-builder.ts (1)
1-5: Header Comment: Do not modify by hand.The header comment clearly instructs not to modify the file by hand and to use the code generation tool instead. This is important for maintainability and ensuring that changes are made in the source JSONSchema and not directly in the TypeScript file.
packages/adocodegen/src/cross-chain-swap/1.0.0/CrossChainSwapContractTs.message-builder.ts
Show resolved
Hide resolved
packages/adocodegen/src/cross-chain-swap/1.0.0/CrossChainSwapContractTs.message-builder.ts
Show resolved
Hide resolved
packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.message-builder.ts
Show resolved
Hide resolved
packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.message-builder.ts
Show resolved
Hide resolved
packages/adocodegen/src/address-list/1.0.0/AddressListContractTs.types.ts
Show resolved
Hide resolved
packages/adocodegen/src/auction/1.0.0/AuctionContractTs.message-builder.ts
Show resolved
Hide resolved
packages/adocodegen/src/auction/1.0.0/AuctionContractTs.message-builder.ts
Show resolved
Hide resolved
|
@coderabbitai resolve |
Actions performedComments resolved. |
|
@coderabbitai review |
Actions performedReview triggered.
|
|
Please ignore change requests for adocodegen packages, they are autogenerated. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
packages/gql/package.jsonis excluded by!packages/gql/**pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (2)
- .coderabbit.yaml (1 hunks)
- package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- .coderabbit.yaml
Additional comments not posted (6)
package.json (6)
11-11: Clarification of path in script command approved.The addition of
./beforelocal_libsin therimrafcommand clarifies the relative path, which is a good practice to ensure the command behaves as expected in different execution contexts.
18-18: Dependency update approved.Updating
@changesets/clifrom^2.26.2to^2.27.8is likely to include bug fixes and minor features, which can improve stability and functionality.
20-20: Patch update to dependency approved.The update of
rimraffrom^4.4.0to^4.4.1is a patch level change, typically addressing bug fixes, which is beneficial for maintaining the stability of the package.
30-30: Override update forfollow-redirectsapproved.Specifying
"follow-redirects@<=1.15.5": ">=1.15.6"ensures that versions lower than1.15.6are not used, likely addressing important bug fixes or security patches.
31-31: Override update forbracesapproved.The specification
"braces@<3.0.3": ">=3.0.3"ensures that only versions3.0.3or newer are used, likely for compatibility or security improvements.
32-33: Override updates forwsandmicromatchapproved.The specifications
"ws@>=7.0.0 <7.5.10": ">=7.5.10"and"micromatch@<4.0.8": ">=4.0.8"ensure that only newer versions are used, likely addressing compatibility, performance, or security concerns.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
packages/gql/CHANGELOG.mdis excluded by!packages/gql/**packages/gql/package.jsonis excluded by!packages/gql/**
Files selected for processing (2)
- .changeset/pre.json (1 hunks)
- .changeset/shaggy-carrots-serve.md (1 hunks)
Files skipped from review due to trivial changes (2)
- .changeset/pre.json
- .changeset/shaggy-carrots-serve.md
There was a problem hiding this comment.
This merge is primarily focused on the updated releases for GraphQL and AndromedaJS and their updates and bug resolutions. These two will be pushed out through the dependency based apps. (CLI release is slated for later, and overlap is discussed in FW section below).
Future Work:
Some additional changes are slated for the CLI (and should be completed in the near future).
Note - Ignore adocodegen diffs as these are autogerated
ANDRJS
Cosmwasm Client
As there are multiple chains AOS is interacting with, it was hard to manage clients using their own packages specially because it all comes to signer and pubkey. Major refactor is done to
CosmWasmClient using byAndromedaClientto support multiple pubkey. With this update, custom packages for terra and archway clients were removed.Wallet Client
Wallet Client is also updated to now use mnemonic or private key and encrypt it using its own encryption method. This will help clients to use same wallet for multiple chains which was not possible with previous Client. (This feature has more impact on CLI wallet feature which we will discuss below)
Schema Client and GQL Client
Schema client was internally using env variable for fallback which was not visible cleary to library users. Now Andromeda Client needs schema url as constructor.
Gql client is not part of AndromedaClient but it was also using env variable, you can update gql client now using
setGQLSdkUri.Bug Fixes
With latest updates to chains, there were some bugs with msg parsing related to store code mainly. Now with new Cosmwasm client implementation, all messages are wrapped inside there own encoder and we have implemented event parsing logic with all the fallbacks that are needed to support events from multiple chains
CLI
Wallet Command
Wallet command is refactored completely and now supports both mnemonic and private key. In contrast to previous version were you need to store your wallet for each chain, now same wallet can be used for multiple chain. Encryption method for wallet store has been updated (Any suggestion regarding other, more secure encyption method are highly welcomed).
ENV Command
One of the issues that I personally face with any wallet provider is isolation of different env. I want to use 5-6 testing wallets but don't want to accidently use these for any mainnet stuff. With new env you can isolate your keys and configs inside an env and quickly shift between them.
Chain Command
Updated localchains storage to fix all the local config related bugs. Localchains are also part of env so you can set different chains per env.
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Chores
package.jsonfor improved clarity and compatibility.