Fix: Remove thread blocking logic from SdkProvider implementation #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anaghask-google
commented
Oct 23, 2024
anaghask-google
commented
- Thread blocking code removed from SdkProvider implementation and added to a new initialise API in mediator (example-sdk).
- RA_SDK (existing-sdk) will call both SdkSandboxController#loadSdk("mediatorSdk") and mediatorSdkService.initialise(). This will be done by the App in the long term.
anaghask-google
requested review from
kolea2,
notmariazoe,
cshmerling,
robclifford27,
erintwalsh and
jmarkoff
as code owners
|
Will wait until #125 is addressed to proceed with this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.