Initialize plugins and custom maps in MapTrek instead of MainActivity #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because MainActivity can be recreated with a saved bundle in two different cases: - on orientation changes, when only the activity is recreated - after the process has been killed In the first case, mMapIndex = application.getExtraMapIndex() worked well, though in the second case, MapTrek.mExtraMapIndex got cleared and maps from content providers hadn't had any chance to get initialized up to now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because MainActivity can be recreated with a saved bundle in two different cases:
In the first case, mMapIndex = application.getExtraMapIndex() worked well,
though in the second case, MapTrek.mExtraMapIndex got cleared and maps from content providers hadn't had any chance to get initialized up to now.
I'm not sure if the approach I adopted will be fine with you. Unfortunately, plugin management cannot satisfactorily be restricted to
BasePluginActivitybecause plugins must be initialized on application startup, not when the activity is created.