updated rubocop, cosmetics

andrew-aladev · Jul 13, 2020 · d98eed3 · d98eed3
1 parent 829e0b3
commit d98eed3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -69,19 +69,29 @@ Layout/SpaceAroundMethodCallOperator:
 
 Lint/DeprecatedOpenSSLConstant:
   Enabled: true
+Lint/DuplicateElsifCondition:
+  Enabled: true
 Lint/MixedRegexpCaptureTypes:
   Enabled: true
 Lint/RaiseException:
   Enabled: true
 Lint/StructNewOverride:
   Enabled: true
 
+Style/ArrayCoercion:
+  Enabled: true
 Style/BisectedAttrAccessor:
   Enabled: true
+Style/CaseLikeIf:
+  Enabled: true
 Style/ExponentialNotation:
   Enabled: true
+Style/HashAsLastArrayItem:
+  Enabled: true
 Style/HashEachMethods:
   Enabled: true
+Style/HashLikeCase:
+  Enabled: true
 Style/HashTransformKeys:
   Enabled: true
 Style/HashTransformValues:
@@ -90,6 +100,8 @@ Style/RedundantAssignment:
   Enabled: true
 Style/RedundantFetchBlock:
   Enabled: true
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 Style/RedundantRegexpEscape:

diff --git a/lib/zstds/stream/writer_helpers.rb b/lib/zstds/stream/writer_helpers.rb
@@ -31,9 +31,10 @@ def printf(*args)
       end
 
       def putc(object, encoding: ::Encoding::BINARY)
-        if object.is_a? ::Numeric
+        case object
+        when ::Numeric
           write object.chr(encoding)
-        elsif object.is_a? ::String
+        when ::String
           write object[0]
         else
           raise ValidateError, "invalid object: \"#{object}\" for putc"