Fix autoplay & add initialFrame prop #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrepolischuk Could you take a look :) |
| if (autoPlay !== this.props.autoPlay) { | ||
| if (autoPlay) { | ||
| this.nextFrame() | ||
| } else { | ||
| this.stop() | ||
| } | ||
| } | ||
|
|
||
| if (initialFrame !== this.props.initialFrame) { |
There was a problem hiding this comment.
why you update current frame when change initial frame property? it seems to me that initialFrame is the same with input's defaultValue property, but default value works only on mount (not on update)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example code to issue reproduce:
<Rotation cycle={true} autoPlay={this.state.autoPlay} onChange={(frame) => { if (frame === 10) { this.setState({ autoPlay: false })Expected behavior: Start initially autoPlay then stop spinning after 10 frame.
Issue: The prop autoPlay changes to false, method stop fires but spinning doesn't stop because of async setTimeout in
nextFramemethodAlso I added initialFrame prop