Skip to content

Commit

Permalink
Reserve enough space in PF_makestatic for worst case scenario
Browse files Browse the repository at this point in the history 
Fixes off-by-one introduced in 22f4422
  • Loading branch information
@andrei-drexler
andrei-drexler committed Dec 22, 2023
1 parent 20119ca commit 27221f3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Quake/pr_cmds.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1637,7 +1637,7 @@ static void PF_makestatic (void)
}
}

SV_ReserveSignonSpace (33);
SV_ReserveSignonSpace (34);

if (bits)
{
Expand Down

5 comments on commit 27221f3

@andrei-drexler
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sezero This should be changed in QS as well.

@sezero
Copy link

@sezero sezero commented on 27221f3 Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will apply shortly.

@sezero
Copy link

@sezero sezero commented on 27221f3 Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will apply shortly.

Applied as sezero@9785099 -- thanks.

@sezero
Copy link

@sezero sezero commented on 27221f3 Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was originally 33, but with merge commit 13c2990
it magically get bumped to 34 without a specific explanation. I hate merge commits..

@andrei-drexler
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while, but I'm pretty sure I bumped it to 34 then because of the scale byte that was added in that commit.

I hate merge commits, too. Having to go through a ton of merge conflicts manually is very error-prone, so I really appreciate you keeping an eye out for potential mistakes.

Please sign in to comment.