Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed theme toggling bug #229

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

Mastermind-sap
Copy link
Contributor

Problem / Issue No.

Describe Problem / Root Cause

  • When you first build the app on any device or install it for first time, it initializes the theme to system's default theme. If the system theme is light mode there is no visible error but if it is dark mode the toggling button will skip the press for one click as it will set System (presumed to be Light mode by the code given in home_page.dart )mode to Dark mode first.

Solution proposed

  • I have taken initial theme as the light mode and toggled between the dark and light modes which were defined in the program from before.

Additional Information

  • Moreover it is saving the theme currently upon closing the app if it doesn't we can store it using shared pref.

Screenshots

  • Original Screenshot (Problem/Issue)
2024-06-18.03-30-33.mp4
  • Updated Screenshot (Fixes/Solution)
2024-06-18.03-48-44.mp4

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible.

@andoriyaprashant andoriyaprashant merged commit 70f0d20 into andoriyaprashant:main Jun 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Initial theme toggling bug
2 participants