[BUGFIX] Use different cache keys for different bucket URLs #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When having multiple S3-based storages in TYPO3, the file tree view shows the same folders for all storages since commit > 6d01c1a > Make some caches configurable, fixes a caching issue > and minor performance improvements The culprit is that the caching layer does not take the bucket configuration into account, leading to the same cache key "/" for all storages. This commit uses the S3 client endpoint as prefix for all cache keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having multiple S3-based storages in TYPO3, the file tree view shows the same folders for all storages since commit
The culprit is that the caching layer does not take the bucket configuration into account, leading to the same cache key "/" for all storages.
This commit uses the S3 client endpoint as prefix for all cache keys.