Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#159236202 Filter Exercise and Ingredient translations better #28

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RrNn
Copy link
Collaborator

@RrNn RrNn commented Aug 24, 2018

What does this PR do?

  • This PR allows the translations of Exercises and Ingredients better. Initially, say for exercises, only those that were registered in English were shown regardless of the language selected, but now that's not the case, each selected language comes with its own exercises in that language.

How should this be manually tested?

  • Clone this application as described in the README.
  • Under the projects directory, git checkout ft-trans-ex-ingrdient-159236202
  • After logging in visit the endpoint http://127.0.0.1:8000/en/exercise/overview/ and change the language to any of your choice, the exercises should change accordingly.
  • Visiting the endpoint http://127.0.0.1:8000/en/nutrition/ingredient/overview/ and changing the language behaves like explained above too. The displayed ingredients are of the selected languages.

Relevant PT story

@coveralls
Copy link

coveralls commented Aug 24, 2018

Pull Request Test Coverage Report for Build 468

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 13 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.09%) to 93.113%

Files with Coverage Reduction New Missed Lines %
wger/exercises/tests/test_equipment.py 1 100.0%
wger/exercises/tests/test_categories.py 1 100.0%
wger/core/tests/base_testcase.py 2 97.4%
wger/manager/forms.py 2 100.0%
wger/manager/views/set.py 3 96.33%
wger/exercises/tests/test_exercise.py 4 100.0%
Totals Coverage Status
Change from base Build 442: -0.09%
Covered Lines: 12507
Relevant Lines: 13432

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants