Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from dataclass-wizard to mashumaro #389

Merged
merged 9 commits into from
Nov 8, 2023
Merged

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Nov 8, 2023

This fixes the issues we're seeing with dataclass-wizard by swapping it out with mashumaro. This additionally swaps the CI validations to a matrix to test multiple versions of python. This was done by adding tox back into the project. Nothing has changed from the make unit workflow, however if you want to test with all supported versions of python (and you have already installed them locally) then you can run make unit-matrix. CI runs with this matrix configuration in mind.

Note: this updates the default python version in CI to python 3.11. This depends on the defaults in the bootstrap action locally in this repo. SInce this is not a single source of truth, we're at risk of drift here (relative to the python versions in the test matrix).

TODO:

  • ensure CI is passing, and each python version in each job is correct (in the matrix run)
  • passing quality gate: ensure all providers are tested

@wagoodman wagoodman force-pushed the drop-dataclass-wizard branch 2 times, most recently from 0676960 to 0c5a350 Compare November 8, 2023 16:23
@wagoodman wagoodman added the run-pr-quality-gate Triggers running of quality gate on PRs label Nov 8, 2023
@wagoodman wagoodman force-pushed the drop-dataclass-wizard branch from 0c5a350 to 5cc5568 Compare November 8, 2023 16:27
@westonsteimel
Copy link
Contributor

westonsteimel commented Nov 8, 2023

Hmm, something is off with the unit tests. They're all running on python 3.10
https://github.com/anchore/vunnel/actions/runs/6801136283/job/18491300263?pr=389#step:4:15

@westonsteimel
Copy link
Contributor

Ah, looks like something weird happening in the poetry install: https://github.com/anchore/vunnel/actions/runs/6801136283/job/18491300544?pr=389#step:3:103

@westonsteimel
Copy link
Contributor

installing it in python3.10

Signed-off-by: Weston Steimel <[email protected]>
@westonsteimel
Copy link
Contributor

Hmm, I'm not really sure why it is only installing poetry in python3.10. I tried bumping to a newer poetry version but that did nothing

@wagoodman
Copy link
Contributor Author

I've removed the tox-gh-actions tool that I was trying to use to facilitate the matrix seamlessly. The trade off is adding some seams: the makefile is not the entrypoint anymore for running tox.

Signed-off-by: Alex Goodman <[email protected]>
@zhill
Copy link
Member

zhill commented Nov 8, 2023

I suggest looking at the tox allowlist section. it's using poetry from the initial install I think rather than from the tox matrix.

@wagoodman wagoodman force-pushed the drop-dataclass-wizard branch from c57d1ba to 9f70be2 Compare November 8, 2023 20:27
Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman force-pushed the drop-dataclass-wizard branch from 9f70be2 to a16e4df Compare November 8, 2023 20:29
Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman merged commit 63f1856 into main Nov 8, 2023
20 checks passed
@wagoodman wagoodman deleted the drop-dataclass-wizard branch November 8, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-pr-quality-gate Triggers running of quality gate on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants