-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from dataclass-wizard to mashumaro #389
Conversation
Signed-off-by: Alex Goodman <[email protected]>
0676960
to
0c5a350
Compare
Signed-off-by: Alex Goodman <[email protected]>
0c5a350
to
5cc5568
Compare
Hmm, something is off with the unit tests. They're all running on python 3.10 |
c7881ac
to
5cc5568
Compare
Ah, looks like something weird happening in the poetry install: https://github.com/anchore/vunnel/actions/runs/6801136283/job/18491300544?pr=389#step:3:103 |
installing it in python3.10 |
Signed-off-by: Weston Steimel <[email protected]>
Hmm, I'm not really sure why it is only installing poetry in python3.10. I tried bumping to a newer poetry version but that did nothing |
Signed-off-by: Alex Goodman <[email protected]>
I've removed the |
Signed-off-by: Alex Goodman <[email protected]>
I suggest looking at the tox allowlist section. it's using poetry from the initial install I think rather than from the tox matrix. |
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
c57d1ba
to
9f70be2
Compare
Signed-off-by: Alex Goodman <[email protected]>
9f70be2
to
a16e4df
Compare
Signed-off-by: Alex Goodman <[email protected]>
This fixes the issues we're seeing with dataclass-wizard by swapping it out with mashumaro. This additionally swaps the CI validations to a matrix to test multiple versions of python. This was done by adding
tox
back into the project. Nothing has changed from themake unit
workflow, however if you want to test with all supported versions of python (and you have already installed them locally) then you can runmake unit-matrix
. CI runs with this matrix configuration in mind.Note: this updates the default python version in CI to python 3.11. This depends on the defaults in the bootstrap action locally in this repo. SInce this is not a single source of truth, we're at risk of drift here (relative to the python versions in the test matrix).
TODO: