chore: add snapshot tests to Amazon provider #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sort previously non-deterministic parts of the output so that the snapshot comparison can be deterministic. Signed-off-by: Will Murphy <[email protected]>
willmurphyscode
added
provider:amazon
13 tasks
wagoodman
approved these changes
Oct 18, 2023
wagoodman
removed
the
run-pr-quality-gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sort previously non-deterministic parts of the output so that the snapshot comparison can be deterministic.
See #309.
Because there are changes to the provider itself, I've done the following additional testing:
make dev providers=amazon, runmake update-db, and thengrype amazonlinux:2.0.20230926.0and compared that to running the same grype command outside the development shell, and it finds the same set of vulnerabilities.