Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly quality gate notification #324

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix nightly quality gate notification #324

merged 1 commit into from
Oct 10, 2023

Conversation

wagoodman
Copy link
Contributor

There are a couple problems:

  • The gate logic was explicitly checking if there was a failure instead of checking explicitly for success (and failing otherwise)
  • The notification was on the PR gate, not the nightly gate

@wagoodman wagoodman force-pushed the fix-qg-notification branch from 451676c to b0783ad Compare October 10, 2023 13:46
@wagoodman wagoodman requested a review from a team October 10, 2023 13:46
@wagoodman wagoodman merged commit 0bd4751 into main Oct 10, 2023
6 checks passed
@wagoodman wagoodman deleted the fix-qg-notification branch October 10, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wagoodman