chore: improve unit tests in debian provider #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provider is intentionally resilient to malformed records, and implements this resilience by logging and continuing on when any exception is thrown. However, this prevents the unit tests from many errors in the implementation of the provider. Therefore, spy on the provider and fail unit tests if it is logging exceptions. Signed-off-by: Will Murphy <[email protected]>
willmurphyscode
changed the title
wagoodman
approved these changes
Sep 29, 2023
willmurphyscode
changed the title
andrew
pushed a commit
to andrew/vunnel
that referenced
this pull request
Oct 4, 2023
The provider is intentionally resilient to malformed records, and implements this resilience by logging and continuing on when any exception is thrown. However, this prevents the unit tests from many errors in the implementation of the provider. Therefore, spy on the provider and fail unit tests if it is logging exceptions. Signed-off-by: Will Murphy <[email protected]> Signed-off-by: Andrew Nesbitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider is intentionally resilient to malformed records, and implements this resilience by logging and continuing on when any exception is thrown. However, this prevents the unit tests from many errors in the implementation of the provider. Therefore, spy on the provider and fail unit tests if it is logging exceptions.
Part of #309, but doesn't resolve it.