fix: terminal clobbering #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <[email protected]>
| } else { | ||
| m.program.Kill() | ||
| } | ||
| _ = runWithTimeout(250*time.Millisecond, func() error { |
There was a problem hiding this comment.
Just to make sure I understand the change, we're basically saying, "if we're exiting in a controlled manner, wait for the UI to finish. Otherwise, wait 250 milliseconds for the UI to finish," so that the UI has a better chance to restore the terminal to its normal state?
There was a problem hiding this comment.
Yes. If we're in a "force shutdown" mode, wait only a short time for the handler and UI to complete. This short time, however, is ages longer than the near instantaneous end of the main thread in the program, which was the culprit for leaving the terminal in a bad state.
There was a problem hiding this comment.
Thanks for the explanation!
willmurphyscode
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the fix from anchore/grype#1505 to avoid potential terminal clobbering