use "path/filepath" to build file path #1767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found
path.Dir()
which looks misuse.package "path" suggests:
NOTE: I found this just scanning project statically. I haven't reproduced "real" problem. Even I don't have Windows environment.
This line looks to be covered by existing test.
grype/internal/format/writer_test.go
Lines 173 to 178 in 548da9e