Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove config from help template #41

Merged
merged 3 commits into from
Feb 9, 2024
Merged

feat: remove config from help template #41

merged 3 commits into from
Feb 9, 2024

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Feb 7, 2024 •
edited
Loading

tested locally by importing changes into syft; note the panic is gone and the config has been removed from the help summary in favor of --- anchore/syft#2598

Screenshot 2024-02-07 at 11 56 35 AM

@spiffcs
feat: remove config from help template
94b0b46 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs
chore: remove unused code
41a8497 
Signed-off-by: Christopher Phillips <[email protected]>
wagoodman
wagoodman reviewed Feb 8, 2024
View reviewed changes
setup_config.go Outdated Show resolved Hide resolved
@spiffcs
chore: pr comments
a57ec6c 
Signed-off-by: Christopher Phillips <[email protected]>
kzantow
kzantow approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 -- I had a vague recollection of some differences in the help template vs. the default included in Cobra, but looking at the diff from this PR vs. main in syft, I only see that the default outputs Examples: before the examples, which is better anyway.

@spiffcs spiffcs merged commit 06cf78f into main Feb 9, 2024
4 checks passed
@spiffcs spiffcs deleted the remove-panic branch February 9, 2024 17:02
@kzantow kzantow linked an issue Feb 10, 2024 that may be closed by this pull request
Panic occurs when config on disk is not equivalent to app config #40
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman left review comments

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic occurs when config on disk is not equivalent to app config
3 participants
@spiffcs @wagoodman @kzantow