Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to specify how long to wait for tingle reboot #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow user to specify how long to wait for tingle reboot #1

wants to merge 1 commit into from

Conversation

go8ose
Copy link

@go8ose go8ose commented Jun 6, 2012

Rather than forcing a wait of ten minutes to reboot, this change means you can specify how long to wait when you call tingle. For example for a 2 minute wait for reboot, you would call:
tingle reboot 2

It's the icing on the cake I need to use tingle in my environment.

Rather than forcing a wait of ten minutes to reboot, this change means you
can have a 2 minute wait for reboot, by calling
 tingle reboot 2
@saj
Copy link
Contributor

saj commented Jan 7, 2013

I agree: the fixed ten-minute delay should be substituted with a tweakable value.

I'm not taken by the idea of introducing an additional optional argument to the user interface just for this case. All variable configuration policy that might affect a tingle run should be nailed down somewhere durable before the trigger is pulled with tingle ACTION.

Geoff, would a variable in a configuration file work for you? e.g.:

# /etc/tingle/tingle.conf

REBOOT_DELAY=2

@go8ose
Copy link
Author

go8ose commented Jan 8, 2013

On Mon, 07 Jan 2013 15:09:34 -0800, Saj Goonatilleke
[email protected] wrote:

I agree: the fixed ten-minute delay should be substituted with a
tweakable value.

I'm not taken by the idea of introducing an additional optional argument
to the user interface just for this case. All variable configuration
policy that might affect a tingle run should be nailed down somewhere
durable before the trigger is pulled with tingle ACTION.

Geoff, would a variable in a configuration file work for you? e.g.:

# /etc/tingle/tingle.conf

REBOOT_DELAY=2

Yes, that would work for me.

Geoff Crompton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants