Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OpenAIRE plugin #20

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

cameronneylon
Copy link
Collaborator

Added a plugin that determines free-to-read status from OpenAIRE and added appropriate tests. This does one call per DOI which will be a bit harsh potentially for the future but will work for the moment. Tested for a reasonable number of cases and 100% coverage of the new scraper.

Need to add final tests to ensure we actually get the right answer and then would probably be a good idea to re-factor the test cases for a cleaner approach and more readable code.
Could still do with cleaning up the test cases and iterating over them in a cleaner fashion but this works and is giving the right answers.
@ananelson
Copy link
Owner

Do you have an oa_excel_article.py file which you haven't added to the repo yet?

@cameronneylon
Copy link
Collaborator Author

I do, but it was only a residue of trying to fix that database issue by
reducing the fields displayed. So its not anything that matters. Where is
the reference to it?

From: Ana Nelson [email protected]
Reply-To: ananelson/oacensus
<reply+i-34455868-e252e4152df365c81029c584d94fcf9cb2180665-33832@reply.githu
b.com>
Date: Thursday, 12 June 2014 11:22
To: ananelson/oacensus [email protected]
Cc: Cameron Neylon [email protected]
Subject: Re: [oacensus] Added OpenAIRE plugin (#20)

Do you have an oa_excel_article.py file which you haven't added to the repo
yet?


Reply to this email directly or view it on GitHub
#20 (comment) .

@ananelson
Copy link
Owner

If you look at the "Files changed" tab, it's in load_plugins.py

You might want to do a:
find . -name "*.pyc" -delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants